Adds missing fields for iSCSI volumes#2844
Open
gwkunze wants to merge 1 commit intohashicorp:mainfrom
Open
Conversation
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
None as far as I know
Description
This adds the missing fields
chapAuthDiscovery,chapAuthSession,initiatorName,portals, andsecretRefto the iSCSI volume mounts.From my limited testing the changes work, but as my knowledge of iSCSI is next to non-existent I can only say the specs seem to be correctly generated.
I noticed from my diff my editor has removed some trailing whitespaces in some of the files I've edited. I hope that is not an issue.
In case this matters to someone, I didn't use any AI for the PR. (Not out of conviction, just couldn't be bothered to set it up on my computer)
Acceptance tests
Output from acceptance testing:
N/A
I've run
make testbut currently do not have access to a cluster I can runmake testaccon.Release Note
Release note for CHANGELOG:
References
Community Note